Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .jshintignore file #113

Open
SET001 opened this issue Jul 28, 2015 · 3 comments · May be fixed by #119
Open

Add support for .jshintignore file #113

SET001 opened this issue Jul 28, 2015 · 3 comments · May be fixed by #119

Comments

@SET001
Copy link

SET001 commented Jul 28, 2015

Add support for .jshintignore file. Without this there are no way to set ignored files.
My current solution is to add // jshint ignore: start on the top of each file that should be ignored. But this is not as good as settings once something like spec/*.js in .jshintignore.
jhinzmann added a commit to jhinzmann/Sublime-JSHint that referenced this issue Oct 18, 2015
@jhinzmann
Add support for .jshintignore files
c987b41 
Search for `.jshintignore` files in parent directories and
evaluate ignore patterns by utilizing the python pathspec library

This resolves victorporof#59 and resolves victorporof#113
@jhinzmann jhinzmann linked a pull request Oct 18, 2015 that will close this issue
Open
@victorporof
Copy link
Owner

Sorry for taking so long to get to this. Is it possible to rebase your changes to the current tip? Otherwise I'll look into it. Thank you!

@victorporof victorporof changed the title add support for .jshintignore file Add support for .jshintignore file Jan 18, 2016
@arronmabrey
Copy link

@SET001 Yes this would be awesome. I actually have an issue where I'm using script tags for templating in an index.html file. e.g.

<script type="text/template">
...HTML MARKUP...
</script>

Obviously JSHint goes crazy trying to "hint" html markup in that script tag. It would be great to ignore these html files.

jhinzmann added a commit to jhinzmann/Sublime-JSHint that referenced this issue Feb 16, 2017
@jhinzmann
Add support for .jshintignore files
f48850e 
Search for `.jshintignore` files in parent directories and
evaluate ignore patterns by utilizing the python pathspec library.

According to the [jshint docs](http://jshint.com/docs/cli/#ignoring-files),
only the first found `.jshintignore` is used by jshint.
This plugin should mimic that behaviour.

This resolves victorporof#59 and resolves victorporof#113
@jhinzmann
Copy link

A comment on my pull-request #119 by @austil got my attention on this (maybe a bit late, but better than never).
I just rebased my changes onto the current master without any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for .jshintignore files jhinzmann/Sublime-JSHint
4 participants
@SET001 @arronmabrey @victorporof @jhinzmann