Add Picture-in-Picture icons #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Also, ignore travis, it's not really set up to verify things just yet :) |
beaufortfrancois
force-pushed
the
pip-icons
branch
from
7939b17 to
5fa24d2
Compare
See #43 |
thijstriemstra
approved these changes
May 22, 2019
gkatsev
approved these changes
May 22, 2019
|
@gkatsev I don't see Picture-in-Picture icons in https://videojs.github.io/font/. Is that intended? |
|
@beaufortfrancois the preview html wasn't updated (in this PR) it seems update: oops, not true: https://github.com/videojs/font/blob/master/index.html#L229 |
|
Oooh! https://github.com/videojs/font/blob/gh-pages/index.html was NOT actually. It looks like |
|
I updated it to just use the master branch instead of gh-pages. So, it should be up-to-date now. |
gkatsev
pushed a commit
to videojs/video.js
that referenced
this pull request
Jun 18, 2019
Adds a new PictureInPictureToggle component in the controls bar of the player. It depends on videojs-font 3.2.0 (videojs/font#41) for icons. Final spec piece from #5824.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following videojs/video.js#5824 (comment), this PR adds two new icons for Picture-in-Picture.