Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support disablepictureinpicture #6341

Closed
nailfor opened this issue Nov 29, 2019 · 4 comments
Closed

support disablepictureinpicture #6341

nailfor opened this issue Nov 29, 2019 · 4 comments
Labels
outdated Things closed automatically by stalebot

Comments

@nailfor
Copy link

nailfor commented Nov 29, 2019

Please, add check, if disablepictureinpicture is preset in Video tag

27 :   constructor(player, options) {
28 :     super(player, options);
29 :     this.on(player, ['enterpictureinpicture', 'leavepictureinpicture'], this.handlePictureInPictureChange);
30 : 
31 :     // TODO: Activate button on player loadedmetadata event.
32 :     // TODO: Deactivate button on player emptied event.
33 :     // TODO: Deactivate button if disablepictureinpicture attribute is present.
34 :     if (!document.pictureInPictureEnabled) {
35 :       this.disable();
36 :     }
37 :   }
@welcome
Copy link

welcome bot commented Nov 29, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@stale
Copy link

stale bot commented Jan 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jan 28, 2020
@stale stale bot closed this as completed Feb 4, 2020
@gkatsev gkatsev reopened this Mar 25, 2020
@stale stale bot removed the outdated Things closed automatically by stalebot label Mar 25, 2020
@stale stale bot closed this as completed Apr 1, 2020
@gkatsev gkatsev reopened this Apr 1, 2020
@stale
Copy link

stale bot commented Jun 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jun 1, 2020
@mister-ben
Copy link
Contributor

added in #6378

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated Things closed automatically by stalebot
Projects
None yet
Development

No branches or pull requests

3 participants