feat: adds disablePictureInPicture method to the player API. #6378
Conversation
|
This PR is also related to #5824 |
|
Any news on this? |
|
I'm still waiting for review. I am pretty sure that @gkatsev will do the review sooner or later but it is hard to tell when this will happen exactly... |
There was a problem hiding this comment.
Thanks @gjanblaszczyk. Only thought is about switching to an event rather than calling the PiPToggle directly.
src/js/tech/html5.js
Outdated
| @@ -1747,7 +1764,8 @@ Html5.resetMediaElement = function(el) { | |||
| // Wrap native properties with a setter in this format: | |||
| // set + toTitleCase(name) | |||
| // The list is as follows: | |||
| // setVolume, setSrc, setPoster, setPreload, setPlaybackRate, setDefaultPlaybackRate | |||
| // setVolume, setSrc, setPoster, setPreload, setPlaybackRate, setDefaultPlaybackRate, | |||
| // setDisablePictureInPicture | |||
There was a problem hiding this comment.
thanks for adding that here. Makes grepping through the code possible.
| @@ -39,6 +39,7 @@ QUnit.test('should be able to access expected player API methods', function(asse | |||
| assert.ok(player.textTracks, 'textTracks exists'); | |||
| assert.ok(player.requestFullscreen, 'requestFullscreen exists'); | |||
| assert.ok(player.exitFullscreen, 'exitFullscreen exists'); | |||
| assert.ok(player.disablePictureInPicture, 'disablePictureInPicture exists'); | |||
There was a problem hiding this comment.
thanks, though, I wonder if these tests even run anymore... 🤔
|
Thanks for your patience, needed to take some time away from answering issues and reviewing PRs. Back at it, at least in some capacity now. |
|
Thanks @gkatsev for the review. I have just added changes according to your comments. |
Description
A proposed fix for #6341
Specific Changes proposed
Add
disablePictureInPicturemethod the the player API.Requirements Checklist