Merge pull request wowsims#4029 from Cyzin1/master

Add blood tap as a major defensive CD option when 4pc T10 is present
vigo2 · Nov 11, 2023 · 64e9835 · 64e9835
2 parents 07a6aab + 189cd26
commit 64e9835
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/sim/deathknight/blood_tap.go b/sim/deathknight/blood_tap.go
@@ -43,4 +43,11 @@ func (dk *Deathknight) registerBloodTapSpell() {
 			dk.BloodTapAura.Activate(sim)
 		},
 	})
+
+	if !dk.Inputs.IsDps && dk.HasSetBonus(ItemSetScourgelordsPlate, 4) {
+		dk.AddMajorCooldown(core.MajorCooldown{
+			Spell: dk.BloodTap,
+			Type:  core.CooldownTypeSurvival,
+		})
+	}
 }
diff --git a/sim/deathknight/tank/TestBloodTank.results b/sim/deathknight/tank/TestBloodTank.results
@@ -603,8 +603,8 @@ dps_results: {
 dps_results: {
  key: "TestBloodTank-AllItems-Scourgelord'sPlate"
  value: {
-  dps: 2378.234
-  tps: 7409.94516
+  dps: 2369.21163
+  tps: 7920.62357
  }
 }
 dps_results: {

diff --git a/ui/tank_deathknight/inputs.ts b/ui/tank_deathknight/inputs.ts
@@ -83,10 +83,10 @@ export const TankDeathKnightRotationConfig = {
 			fieldName: 'bloodTapPrio',
 			label: 'Blood Tap',
 			labelTooltip: 'Chose how to use Blood Tap:<br>\
-				<b>Defensive</b>: Save Blood Tap for activating defensive cds.<br>\
+				<b>Use as Defensive Cooldown</b>: Use as defined in Cooldowns (Requires T10 4pc).<br>\
 				<b>Offensive</b>: Use Blood Tap for extra Icy Touches.',
 			values: [
-				{ name: 'Defensive', value: BloodTapPrio.Defensive },
+				{ name: 'Use as Defensive Cooldown', value: BloodTapPrio.Defensive },
 				{ name: 'Offensive', value: BloodTapPrio.Offensive },
 			],
 			changeEmitter: (player: Player<Spec.SpecTankDeathknight>) => TypedEvent.onAny([player.rotationChangeEmitter, player.talentsChangeEmitter]),