From 31fbe023287bfaaa8f401df80b12c8cbc12a611c Mon Sep 17 00:00:00 2001 From: cyzin Date: Fri, 10 Nov 2023 16:58:56 -0800 Subject: [PATCH 1/2] Add blood tap as a major defensive CD option when 4pc T9 is present --- sim/deathknight/blood_tap.go | 7 +++++++ sim/deathknight/tank/TestBloodTank.results | 4 ++-- ui/tank_deathknight/inputs.ts | 4 ++-- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/sim/deathknight/blood_tap.go b/sim/deathknight/blood_tap.go index 80633001bc..1da2e98997 100644 --- a/sim/deathknight/blood_tap.go +++ b/sim/deathknight/blood_tap.go @@ -43,4 +43,11 @@ func (dk *Deathknight) registerBloodTapSpell() { dk.BloodTapAura.Activate(sim) }, }) + + if !dk.Inputs.IsDps && dk.HasSetBonus(ItemSetScourgelordsPlate, 4) { + dk.AddMajorCooldown(core.MajorCooldown{ + Spell: dk.BloodTap, + Type: core.CooldownTypeSurvival, + }) + } } diff --git a/sim/deathknight/tank/TestBloodTank.results b/sim/deathknight/tank/TestBloodTank.results index 8f36652c44..25a4ffd351 100644 --- a/sim/deathknight/tank/TestBloodTank.results +++ b/sim/deathknight/tank/TestBloodTank.results @@ -603,8 +603,8 @@ dps_results: { dps_results: { key: "TestBloodTank-AllItems-Scourgelord'sPlate" value: { - dps: 2378.234 - tps: 7409.94516 + dps: 2369.21163 + tps: 7920.62357 } } dps_results: { diff --git a/ui/tank_deathknight/inputs.ts b/ui/tank_deathknight/inputs.ts index 53f98dd485..8286e358f2 100644 --- a/ui/tank_deathknight/inputs.ts +++ b/ui/tank_deathknight/inputs.ts @@ -83,10 +83,10 @@ export const TankDeathKnightRotationConfig = { fieldName: 'bloodTapPrio', label: 'Blood Tap', labelTooltip: 'Chose how to use Blood Tap:
\ - Defensive: Save Blood Tap for activating defensive cds.
\ + Use as Defensive Cooldown: Use as defined in Cooldowns (Requires T9 4pc).
\ Offensive: Use Blood Tap for extra Icy Touches.', values: [ - { name: 'Defensive', value: BloodTapPrio.Defensive }, + { name: 'Use as Defensive Cooldown', value: BloodTapPrio.Defensive }, { name: 'Offensive', value: BloodTapPrio.Offensive }, ], changeEmitter: (player: Player) => TypedEvent.onAny([player.rotationChangeEmitter, player.talentsChangeEmitter]), From 189cd2641880bcfd0fd214301c24e7284ffd0e83 Mon Sep 17 00:00:00 2001 From: cyzin Date: Sat, 11 Nov 2023 12:31:02 -0800 Subject: [PATCH 2/2] Update the newly added tooltip for blood tap prio to reference the correct tier set --- ui/tank_deathknight/inputs.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/tank_deathknight/inputs.ts b/ui/tank_deathknight/inputs.ts index 8286e358f2..f254f20def 100644 --- a/ui/tank_deathknight/inputs.ts +++ b/ui/tank_deathknight/inputs.ts @@ -83,7 +83,7 @@ export const TankDeathKnightRotationConfig = { fieldName: 'bloodTapPrio', label: 'Blood Tap', labelTooltip: 'Chose how to use Blood Tap:
\ - Use as Defensive Cooldown: Use as defined in Cooldowns (Requires T9 4pc).
\ + Use as Defensive Cooldown: Use as defined in Cooldowns (Requires T10 4pc).
\ Offensive: Use Blood Tap for extra Icy Touches.', values: [ { name: 'Use as Defensive Cooldown', value: BloodTapPrio.Defensive },