Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use arel_table in Promotion.with_coupon_code and Promotion.coupons #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use arel_table in Promotion.with_coupon_code and Promotion.coupons #133

wants to merge 1 commit into from

Conversation

ankit1910
Copy link

use arel_table for scope .coupons and class_method with_coupon_code in promotion model.

@jitendra
Copy link

jitendra commented Mar 3, 2016

@ankit1910 Please resolve the conflict and ensure that specs are written for the method/scope you modified.

@jitendra jitendra assigned ankit1910 and unassigned jitendra Mar 3, 2016
@ankit1910 ankit1910 assigned jitendra and unassigned ankit1910 Mar 6, 2016
@jitendra
Copy link

jitendra commented Mar 9, 2016

@ankit1910 Please add description to this PR.

@jitendra jitendra assigned ankit1910 and unassigned jitendra Mar 9, 2016
@ankit1910 ankit1910 assigned jitendra and unassigned ankit1910 Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jitendra jitendra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankit1910 @jitendra