Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking only read permissions when asserting function preconditions #532

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

marcoeilers
Copy link
Contributor

Carbon implementation of the changes described here: viperproject/silicon#877

In the Carbon implementation

  • we add a flag to the permission module's state that expresses whether we should consume concrete permission amounts, the default behavior, or just assert read permission without changing the mask,
  • the flag is set when verifying a function and when exhaling a function precondition,
  • to avoid assuming non-aliasing from permission amounts when verifying a function, we change the axiom that limits field permissions to one to be conditional on a new global flag, and assume this flag is true only when verifying predicates or methods

Copy link
Contributor

@gauravpartha gauravpartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, left some minor comments.

@viper-admin viper-admin merged commit 6141770 into master Dec 19, 2024
1 check passed
@viper-admin viper-admin deleted the meilers_assert_read_only branch December 19, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants