Fixing injectivity checks for QPs with multiple quantified variables #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #378. The injectivity check is not actually missing, but it's incorrect (also for fields).
For a QP of the form
forall x, y :: cond ==> P(e1, e2)
, the current code essentially generated the following injectivity check:This is incorrect. We need to check that if the value of any quantified variable changes, we get a different tuple of receiver expressions, but we're checking that if the values of all quantified variables change, we get a different tuple. Essentially, we need to check that the receiver tuple is injective in all quantified variables, but the current check also succeeds if it's injective only in one of them.
So this PR changes the check to