Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker: Point Cloud Usability and Polish #536

Closed
5 of 9 tasks
ibgreen opened this issue Nov 19, 2019 · 6 comments
Closed
5 of 9 tasks

Tracker: Point Cloud Usability and Polish #536

ibgreen opened this issue Nov 19, 2019 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@ibgreen
Copy link
Collaborator

ibgreen commented Nov 19, 2019

v2.x Point cloud category

Also, see discussion at end of #659

  • Goal is to be able to pass output from loader directly to PointCloudLayer...
  • Show how this can be implemented by adding a loader-to-deck-conversion-function in the point cloud example (thanks @Gmadges)
  • Add option (`loader.mesh.pointcloud: true')? to mesh loaders to force/ensure that point clouds geometries are returned from loaders for formats that can encode both point clouds and meshes (e.g. OBJLoader...)
  • Add bounds calculation to all the mesh category loaders (there are ~5 of them), then remove that "clutter" from the example.
  • We could just add the pointcloud example's getBounds function to each point cloud loader (it is small enough) or we could place a helper in the loader-utils module for now, or we could even create a new @loaders.gl/meshes "category module" for mesh-related utilities.

v2.1

Point Cloud Example Features

  • Auto calculate center - Current example starts rotating around center that may not be point cloud center (thanks @Gmadges!)
  • Auto calculate bounding box - Current example does not adapt to model size (thanks @Gmadges!)
  • Support colors - Example throws away all attributes except positions (e.g. colors) (thanks @Gmadges!)

Point Cloud Samples

  • No PLY example with color (ideas: get from Sketchfab or convert from other format?) (thanks @Gmadges)
@ibgreen ibgreen added the help wanted Extra attention is needed label Jan 16, 2020
@Gmadges
Copy link
Contributor

Gmadges commented Jan 31, 2020

I'd like to contribute to this project. I can take a look at this?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Jan 31, 2020

I'd like to contribute to this project. I can take a look at this?

@Gmadges Of course. Happy to engage with you and help you get started.

As preparation, to make sure you have a sense for the high-level ideas behind the code you are going to change, you'll want to read up on:

And read this code

Then we can have a sync and make sure any questions you have get answered, give you some tips for how to proceed etc.

Welcome to loaders.gl!

@Gmadges
Copy link
Contributor

Gmadges commented Jan 31, 2020

Awesome, thank you!

Then we can have a sync and make sure any questions you have get answered, give you some tips for how to proceed etc.

What is the best method to ask questions? here on this issue?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Feb 4, 2020

What is the best method to ask questions? here on this issue?

Yes, of course, we can start here.

You could also sign up for the kepler.gl or deck.gl slack channels. E.g. keplergl/kepler.gl#643

@ibgreen
Copy link
Collaborator Author

ibgreen commented Mar 1, 2020

@Gmadges Many thanks for #659 ! If you want to engage further, my offer of connect on e.g. the slack channel or via other means still stands.

@ibgreen
Copy link
Collaborator Author

ibgreen commented Oct 24, 2023

Mentioning this tracker issue in future release tracker issue, but closing for inactivity

@ibgreen ibgreen closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants