Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select2 4.0.0 #1058

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Select2 4.0.0 #1058

wants to merge 5 commits into from

Conversation

hishammalik
Copy link

This pull request rebases the select2 4.0.0 branch of https://github.com/select2/x-editable and makes further edits to fix select2 compatible version tested with 4.0.4

kevin-brown and others added 3 commits October 29, 2017 22:13
@kevin-brown @hishammalik
Upgrade Select2 to 4.0.0
d632a8e 
This upgrades the included Select2 libraries to 4.0.0.
@kevin-brown @hishammalik
Upgraded support for Select2 4.0.0
baa68df 
x-editable should now work out of the box with Select2 4.0.0.

This changes the headers in the x-editable Select2 files to better
address the current state of Select2.

This fixes some of the tests to better handle Select2 when attached
to a `<select>` in 4.0.0, as well as class name changes.
@hishammalik
working autocomplete with select2-4.0.4 rebased from select2 fork
7cd9f1c
@verschoof
Copy link

@vitalets will this be merged (beside the conflict)?

I would like to use x-editable with select2 4.0.0 and bootstrap4.
Are you gonna lead this project further?
I have seen that the PR's are there but there is nobody that keeps it moving.. :(
Can you let me know what you wanna do with this project? Its the choice to use this or search another solution.

Please let me know, thanks for your time!

@vitalets
Copy link
Owner

vitalets commented Feb 9, 2018

Hi @verschoof !

I'm sad to say there are no active maintainers of x-editable.

  • if it suites your needs in it's current state - try it. Many people are using it as is.
  • If you need some improvements - do not expect they be done. As you said no one moving with PRs.

Personally I would love to breath new life into x-editable. As the idea is useful for many projects. But my time is not enough for that. There is a long discussion of project status in #610.

@mlt
Copy link

mlt commented Jun 10, 2020 •
edited
Loading

I think this misses an important override for tpl template as indicated in #756 for ajax to work.

mohammedfaisal added a commit to aadrian/x-editable-bs4 that referenced this pull request Oct 19, 2023
@mohammedfaisal
Select2 version 4 support added - Copy of https://github.com/arkhitec…
6e1eafd 
…h/x-editabletree/select2-4.0.0

Refer 1: vitalets#1058
Refer 2: https://github.com/arkhitech/x-editable/tree/select2-4.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hishammalik @verschoof @vitalets @mlt @kevin-brown