-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update refresh utils for React Router 7 support #363
base: main
Are you sure you want to change the base?
Conversation
@schiller-manuel from Tan stack start also want to try this out 🔥 |
Co-authored-by: 翠 / green <green@sapphi.red>
Co-authored-by: 翠 / green <green@sapphi.red>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems my suggestion made the lint CI to fail. LGTM if the lint fail is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the full context of what this is trying to solve, but code-wise it looks fine to me
Port of vitejs/vite-plugin-react-swc#191
cc @pcattori
__beforePerformReactRefresh & __getReactRefreshIgnoredExports will not be part of semver until RR7 is stable.