Crashfix: test for empty string in mentions

[davotoula]

Observing a crash when trying to comment on a specific note. Root cause looks a missing hex in the mention tag of the post:

{ "id": "2be8bcd50a46628a08523c4b638406e04d1d7ab75c8f9ede5aaaf568e4bde081", "pubkey": "20986fb83e775d96d188ca5c9df10ce6d613e0eb7e5768a0f0b12b37cdac21b3", "created_at": 1730957039, "kind": 1, "tags": [ [ "p", "", "", "mention" ] ],

Event ID: nevent1qqszh69u659yvc52ppfrcjmrssrwqnga02m4eru7med24atguj77pqgpzamhxue69uhhyetvv9ujumn0wd68ytnzv9hxgtczyqsfsmac8em4m9k33r99e803pnndvylqadl9w69q7zcjkd7d4ssmxqcyqqqqqqgx0u6l0

The isValidHex function specifically fails empty hexes so I filter out the empty hex mention in the calling NewPostViewModel class.

[KotlinGeekDev]

Nice, though the root issue I suspect, is the client producing this event. It will probably need to be reported to them.

[davotoula]

Yes.. I need to check nostr docs whether empty mentions like that are valid.. Or maybe just not defined.

In any case amethyst should expect malformed messages and not crash. Display a toast to user.. Or just ignore silently?

[KotlinGeekDev]

@davotoula you seem not to be the only one to have noticed(based on the replies to that note), and from opening it on many clients, most silently ignore it, and render it as is ("@npub1..."). Only Coracle looks for the referenced profile.

[KotlinGeekDev]

IMHO we should silently ignore it, and inform the devs of the source client for this note.

[KotlinGeekDev]

@davotoula seems to work on Amethyst?

[davotoula]

That's with the debug build from pull request

[KotlinGeekDev]

That's with the debug build from pull request

This is actually with the latest release build.

[davotoula]

@KotlinGeekDev can you please double check? I really don't see how it could work with release build.

Note id: nostr:nevent1qqszh69u659yvc52ppfrcjmrssrwqnga02m4eru7med24atguj77pqgpzamhxue69uhhyetvv9ujumn0wd68ytnzv9hxgtczyqsfsmac8em4m9k33r99e803pnndvylqadl9w69q7zcjkd7d4ssmxqcyqqqqqqgx0u6l0

[KotlinGeekDev]

@KotlinGeekDev can you please double check? I really don't see how it could work with release build.

Note id: nostr:nevent1qqszh69u659yvc52ppfrcjmrssrwqnga02m4eru7med24atguj77pqgpzamhxue69uhhyetvv9ujumn0wd68ytnzv9hxgtczyqsfsmac8em4m9k33r99e803pnndvylqadl9w69q7zcjkd7d4ssmxqcyqqqqqqgx0u6l0

Got it.

[KotlinGeekDev]

@davotoula seems to work(Latest release build downloaded from Obtainium).

[davotoula]

Which reply from above do you think shows it works with latest amethyst release?

[davotoula]

By the way, viewing works.

It crashes if you click the create a comment button.