-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Advanced Queries & Boolean Retrieval #125
Draft
ppanopticon
wants to merge
19
commits into
dev
Choose a base branch
from
feature/advanced-boolean
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There is now a difference between a Query and a Predicate - SimpleBooleanQuery is now called Comparison (a predicate) and exists in different flavours (with support for IN queries) - Adds construct for logical connections (AND, OR, NOT). Signed-off-by: Ralph Gasser <rg@pontius.ch>
…constants. Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
…eader and ScalarDescriptorReader. Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
Signed-off-by: Ralph Gasser <rg@pontius.ch>
…eature/advanced-boolean # Conflicts: # vitrivr-engine-module-pgvector/src/main/kotlin/org/vitrivr/engine/database/pgvector/descriptor/AbstractDescriptorReader.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to refactor queries in general and
BooleanQuery
in particular with eyes on future changes to the query pipeline, such as, late filtering, filters combined with fulltext or NNS queries and predicate pushdown.It incorporates the following changes:
Query
and aPredicate
, the latter of which corresponds to what was considered aQuery
before the PR. TheQuery
object holds additional information such as limits.BooleanPredicate
now comes in different flavours:Comparison
,And
,Or
andNot
Comparison
operators now come in different flavours as well, which correspond to the basic comparison operations provided by most DBMS. This also includes a newComparison.In
predicate.ProximityPredicate
and theSimpleFulltextPredicate
now comes with an optionalBooleanPredicate
filter, with the idea, to execute queries with boundary conditions.The PostgreSQL database backend has been retro-fitted to support these changes. With this PR, the database layer becomes more powerful. It should be able to:
Descriptor
of field A based on aBooleanPredicate
that involves other fields.Retrievable
withDescriptor
of field A based on aBooleanPredicate
that involves other fields.ProximityQuery
andFulltextQuery
with boundary conditions that involves other fields.The PR is currently in draft and open for discussion.