Bugfix/fix wrong tx handling after creating thirdpartyconfig #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors data import event handling in the application to use the id of the ThirdPartyApiConfiguration instead of the whole object. It also relocates the updateLastRun method call to the handleDataImportEvent method from various import classes to keep the logic in one place. This ensures consistency and prevents potential errors if an event is fired without an existing ThirdPartyApiConfiguration.
This commit removes the unused dependency on ThirdPartyApiConfigurationService from several classes. These include WeenatMeasurementImport, SensoterraMeasurementImport, and others. This change simplifies the codebase and removes unnecessary coupling.
The commit involves removing unused imports from several classes belonging to different packages. Specifically, it's related to the removal of the ThirdPartyApiConfigurationService import and reordering of the EmptyAttribute and InstantAttribute imports in multiple integration files.
Amended the DataImportEvent parameter to use the configuration ID instead of the configuration object. This change ensures only necessary data is sent with the event, rather than the whole configuration object.
Updated the asJson() functions in the DevicePosition, DeviceMeasurement, and AgriCrop classes. Every field of the returned JSON string now includes the trim() function, removing any leading or trailing white spaces. This change ensures consistency and cleanliness in the JSON strings produced by these methods.
|
Closes #211 |
Vitrum-LL
approved these changes
Jun 14, 2024
saschadoemer
deleted the
bugfix/fix-wrong-tx-handling-after-creating-thirdpartyconfig
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209