Feature/add new endpoint to resolve all images for a specific channel #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new method in the ImageRepository to search images based on transaction id and channel. Also extended the ImageProcessingIntegrationService to include a new function getAllImagesForTransaction. Created a new endpoint in the ImagesController for making the request to get all images for a transaction. Changed the 'imageChannel' comment in the Image entity for clarity. Created GetAllImagesForTransactionRequest and GetAllImagesForTransactionResponse to handle request and response for the new function.
Expanded the ImageRepository to add new methods for searching and retrieving image transactions. New methods can find transactions within a specific timeframe, as well as find the first image of each transaction. All changes support tenant-specific search.
The ImagesController has been updated to include a more detailed response when listing all transactions for a tenant. A map of transaction IDs and their corresponding image timestamps has been added to this response. The AllTransactionsForTenantResponse class has also been appropriately modified for these changes.
The code changes condense the operation that maps transactions to timestamps into one line. This change improves the code's readability and maintainability, without altering the functionality of the ImagesController.
Vitrum-LL
approved these changes
Jun 28, 2024
saschadoemer
deleted the
feature/add-new-endpoint-to-resolve-all-images-for-a-specific-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.