#91 Fixed 500 on PATCH /promotion/id

vityaman-edu · Apr 30, 2024 · f918acc · f918acc
1 parent bbd7ad3
commit f918acc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/.../src/main/kotlin/ru/vityaman/lms/botalka/app/spring/api/http/endpoint/PromotionHttpApi.kt b/.../src/main/kotlin/ru/vityaman/lms/botalka/app/spring/api/http/endpoint/PromotionHttpApi.kt
@@ -4,13 +4,13 @@ import org.springframework.beans.factory.annotation.Autowired
 import org.springframework.http.HttpStatus
 import org.springframework.http.ResponseEntity
 import org.springframework.web.bind.annotation.RestController
-import ru.vityaman.lms.botalka.app.spring.api.http.error.InvalidPromotionRequestStatus
 import ru.vityaman.lms.botalka.app.spring.api.http.message.toMessage
 import ru.vityaman.lms.botalka.app.spring.api.http.message.toModel
 import ru.vityaman.lms.botalka.app.spring.api.http.server.PromotionRequestDraftMessage
 import ru.vityaman.lms.botalka.app.spring.api.http.server.PromotionRequestMessage
 import ru.vityaman.lms.botalka.app.spring.api.http.server.PromotionRequestPatchMessage
 import ru.vityaman.lms.botalka.app.spring.api.http.server.apis.PromotionApi
+import ru.vityaman.lms.botalka.core.exception.InvalidValueException
 import ru.vityaman.lms.botalka.core.logic.PromotionService
 import ru.vityaman.lms.botalka.core.model.PromotionRequest
 import ru.vityaman.lms.botalka.core.model.User
@@ -27,9 +27,9 @@ class PromotionHttpApi(
 
         when (val status = promotionRequestPatchMessage.status.toModel()) {
             PromotionRequest.Status.CREATED -> {
-                throw InvalidPromotionRequestStatus(
+                throw InvalidValueException(
                     buildString {
-                        append("Can't change promotion request status")
+                        append("Can't change promotion request status ")
                         append("to ${status.toMessage()}")
                     },
                 )

diff --git a/...kotlin/ru/vityaman/lms/botalka/app/spring/api/http/error/InvalidPromotionRequestStatus.kt b/...kotlin/ru/vityaman/lms/botalka/app/spring/api/http/error/InvalidPromotionRequestStatus.kt