Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for #SENOTECHANGE command #81

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

vivaria
Copy link
Owner

@vivaria vivaria commented Oct 26, 2024

TJAPlayer3 implementation details (https://github.com/IepIweidieng/TJAPlayer3/blob/gh-pages/tja.md#senotechange):

  • #SENOTECHANGE can be placed at the start of a measure, or in the middle of the measure
  • It will only apply to 1 note immediately after the command
  • It will override any automatic Don2/Don3/Ka2 assignment (from note clusters)

How it works in tja2fumen:

  • #SENOTECHANGE will be tracked in the TJA measure object
  • It will split the measure into sub-measures (similar to gogo/bpm/etc.)
  • It will only be applied to the first note, after which it will be overwritten
  • We set a manually_set flag to ensure that the manually-chosen value doesn't get overwritten.

Fixes #69.

@vivaria vivaria added the feature New feature or request label Oct 26, 2024
@vivaria vivaria self-assigned this Oct 26, 2024
@vivaria
Copy link
Owner Author

vivaria commented Oct 30, 2024

sakurada gave the 👌 so i'll merge this and create 0.9.0 :)

@vivaria vivaria merged commit 85ea4d6 into main Oct 30, 2024
3 checks passed
@vivaria vivaria deleted the viv/69-add-support-for-senotechange branch October 30, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SENOTES defects and suggestions for additional features
1 participant