Add NestJS peer dependencies as @comet/cms-api peer dependencies
#2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyomair
changed the title
@comet/cms-api peer dependencies@comet/cms-api peer dependencies
johnnyomair
force-pushed
the
nestjs-peer-dependencies
branch
from
79c41bb to
15ba122
Compare
manuelblum
previously approved these changes
Jan 14, 2025
manuelblum
approved these changes
Jan 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While upgrading NestJS I've noticed that they have class-transformer, class-validator, reflect-metadata, and rxjs as peer dependencies. I think it's a good idea that we have them as peer dependencies as well.
Open TODOs/questions