Skip to content

Commit

Permalink
Upgrade Node to 20 (#87)
Browse files Browse the repository at this point in the history
Co-authored-by: Fabian Hoffmann <fabian.hoffmann@vivid-planet.com>
  • Loading branch information
Fabian-Fynn and Fabian Hoffmann authored Jul 31, 2024
1 parent 962e0cd commit 2703141
Show file tree
Hide file tree
Showing 8 changed files with 1,968 additions and 2,855 deletions.
5 changes: 4 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"extends": "@comet/eslint-config/nestjs",
"ignorePatterns": []
"ignorePatterns": [],
"rules": {
"@comet/no-other-module-relative-import": "off"
}
}
54 changes: 27 additions & 27 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,37 +1,37 @@
name: Lint

on:
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+"
branches:
- main
- next
pull_request:
branches:
- main
- next
push:
tags:
- "[0-9]+.[0-9]+.[0-9]+"
branches:
- main
- next
pull_request:
branches:
- main
- next

jobs:
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- run: echo "${{ github.actor }}"
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- run: echo "${{ github.actor }}"

- uses: actions/checkout@v3
- uses: actions/checkout@v3

- name: Use Node.js 14.x
uses: actions/setup-node@v3
with:
node-version: 14
registry-url: "https://registry.npmjs.org"
cache: "yarn" # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 20
registry-url: "https://registry.npmjs.org"
cache: "yarn" # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

- run: yarn install
- run: yarn install

- name: Build
run: yarn build
- name: Build
run: yarn build

- name: Lint
run: yarn lint
- name: Lint
run: yarn lint
4 changes: 2 additions & 2 deletions .github/workflows/release-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Use Node.js 14.x
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 20
registry-url: "https://registry.npmjs.org"
cache: "yarn" # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Use Node.js 14.x
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 20
registry-url: "https://registry.npmjs.org"
cache: "yarn" # https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
20
10 changes: 9 additions & 1 deletion .prettierrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,13 @@
"printWidth": 150,
"tabWidth": 4,
"trailingComma": "all",
"semi": true
"semi": true,
"overrides": [
{
"files": ["*.yml", "*.yaml"],
"options": {
"tabWidth": 2
}
}
]
}
32 changes: 16 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"lib/**/*"
],
"scripts": {
"prepare": "husky install",
"prepare": "husky",
"lint": "run-p lint:eslint lint:tsc",
"lint:eslint": "eslint src/",
"lint:tsc": "tsc",
Expand All @@ -34,29 +34,29 @@
},
"homepage": "https://github.com/vivid-planet/dev-process-manager#readme",
"dependencies": {
"cli-table3": "^0.6.1",
"cli-table3": "^0.6.5",
"colors": "^1.4.0",
"commander": "^9.0.0",
"dotenv": "^16.0.3",
"dotenv-expand": "^10.0.0",
"commander": "^12.1.0",
"dotenv": "^16.4.5",
"dotenv-expand": "^11.0.6",
"log-update": "^4.0.0",
"pidtree": "^0.6.0",
"pidusage": "^3.0.2",
"pretty-bytes": "^5.6.0",
"pretty-bytes": "^6.1.1",
"wait-on": "^7.2.0"
},
"devDependencies": {
"@changesets/cli": "^2.26.2",
"@comet/eslint-config": "^4.0.0",
"@types/node": "^14.0.0",
"@types/pidusage": "^2.0.2",
"@types/wait-on": "^5.3.1",
"eslint": "^8.20.0",
"husky": "^8.0.0",
"lint-staged": "^12.0.0",
"@changesets/cli": "^2.27.7",
"@comet/eslint-config": "^6.8.0",
"@types/node": "^20.14.11",
"@types/pidusage": "^2.0.5",
"@types/wait-on": "^5.3.4",
"eslint": "^8.19.0",
"husky": "^9.1.0",
"lint-staged": "^15.2.7",
"prettier": "^2.0.0",
"typescript": "^4.5.5",
"yarn-run-all": "^3.0.0"
"typescript": "^5.5.3",
"yarn-run-all": "^3.1.1"
},
"engines": {
"node": ">=14"
Expand Down
Loading

0 comments on commit 2703141

Please sign in to comment.