Fixes Google Image Line Chart #3974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinovg
approved these changes
Apr 12, 2024
chenejac
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
@milospp thanks for this quick fix. It works very well. No complaints/suggestions from my side for the code. I suggest merging this into the main branch as soon as possible as a fix for the bug. Later, we can discuss whether we can apply just one approach for all images (quickchart.io API or a library).
chenejac
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Replaced googleapis chart with quickchart.io * Updated to quickchart * Fixed nochart publication count * Replaced ImageSparkline with LineChart
ssvivian
pushed a commit
to projetos-codic-ibict/VIVO
that referenced
this pull request
Jul 2, 2024
* Replaced googleapis chart with quickchart.io * Updated to quickchart * Fixed nochart publication count * Replaced ImageSparkline with LineChart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue 3973
What does this pull request do?
Fixes Google Chart API
Google chart API for generating QR code is replaced with quickchart.io.
Google Chart Sparkline image has been replaced with a Google LineChart due to the discontinuation of the Google API Chart API server, which is no longer available for generating images (Line Chart generates SVG locally). Graphs are configured to be identical as they were before.
Fixed no chart view (only text) mode. There was a problem with loading libraries.
What's new?
The chart on hover shows detailed info
How should this be tested?
Screenshoots
QR codes are generated with quickchart.io
Before (coppied from this VIDEO, that's why picture is dull):
After:
