Красивая навигация #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
vklachkov
commented
Oct 7, 2024
vklachkov
commented
- Виртуальные списки для повышения перфа и починки навигации
- Организаторы
- Жюри
- frontend: Срабатывает защита от закрытия на странице участника без редактирования #28
- frontend: Не работает кнопка "На главную" #29
- frontend: Сохранение позиции скролла при переходе между страницами #30
vklachkov
force-pushed
the
fix-navigation
branch
from
9f20f7a
to
cfa93ff
Compare
DKozachenko
reviewed
Oct 7, 2024
| @if (isParticipantsLoading) { | ||
| <!-- TODO(vklachkov): Wrap cards-container witgh nz-spin and remove if's and style hacks --> |
There was a problem hiding this comment.
Suggested change
| <!-- TODO(vklachkov): Wrap cards-container witgh nz-spin and remove if's and style hacks --> | |
| <!-- TODO(vklachkov): Wrap cards-container width nz-spin and remove if's and style hacks --> |
| max-width: var(--container-width); | ||
| left: 50%; | ||
| transform: translateX(-50%); | ||
| margin: 2em 0em; |
There was a problem hiding this comment.
Через padding если сделать не воркс?
There was a problem hiding this comment.
Не работает. И по хорошему надо и margin убрать, а вместо него заиспользовать paddingstart от самой библиотеки
| transform: translateX(-50%); | ||
| margin: 2em 0em; | ||
|
|
||
| app-participant-card { |
There was a problem hiding this comment.
Добавь карточке класс, а не делай селектор по тегу. Можно как раньше назвать "participant-card"
There was a problem hiding this comment.
А зачем тут класс? Компонент больше нигде не используется
| @@ -79,6 +84,9 @@ export class OrganizerPage extends BaseComponent implements OnInit, OnDestroy { | |||
| protected readonly ParticipantStatus = ParticipantStatus; | |||
| protected readonly Sort = Sort; | |||
| protected readonly Order = Order; | |||
|
|
|||
| private environmentInjector = inject(EnvironmentInjector); | |||
There was a problem hiding this comment.
Suggested change
| private environmentInjector = inject(EnvironmentInjector); | |
| private readonly environmentInjector = inject(EnvironmentInjector); |
| @@ -89,6 +97,9 @@ export class OrganizerPage extends BaseComponent implements OnInit, OnDestroy { | |||
| protected participants: Participant[] = []; | |||
| protected isParticipantsLoading: boolean = false; | |||
|
|
|||
| protected scrollElement = viewChild<ElementRef<HTMLDivElement>>('scrollElement') | |||
There was a problem hiding this comment.
Suggested change
| protected scrollElement = viewChild<ElementRef<HTMLDivElement>>('scrollElement') | |
| protected readonly scrollElement = viewChild<ElementRef<HTMLDivElement>>('scrollElement') |
Вообще не помню, мб можно приватным полем сделать?
Ну и тип для этого всего
| @@ -89,6 +97,9 @@ export class OrganizerPage extends BaseComponent implements OnInit, OnDestroy { | |||
| protected participants: Participant[] = []; | |||
| protected isParticipantsLoading: boolean = false; | |||
|
|
|||
| protected scrollElement = viewChild<ElementRef<HTMLDivElement>>('scrollElement') | |||
| protected virtualizer: AngularVirtualizer<HTMLDivElement, Element>| null = null; | |||
There was a problem hiding this comment.
Suggested change
| protected virtualizer: AngularVirtualizer<HTMLDivElement, Element>| null = null; | |
| protected virtualizer: AngularVirtualizer<HTMLDivElement, Element> | null = null; |
Comment on lines
+167
to
-147
| this.showErrorNotification('Ошибка при получении данных об участниках', err); | ||
|
|
||
| this.isParticipantsLoading = false; | ||
| this.cdr.markForCheck(); | ||
| this.showErrorNotification('Ошибка при получении данных об участниках', err); |
There was a problem hiding this comment.
Эти нотификашки всегда в конце шли, везде так
|
Перенесено на 2025. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.