Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new flag name #48

Merged
merged 22 commits into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 23 additions & 20 deletions .github/workflows/pr-only.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
--health-interval=10s
--health-timeout=5s
--health-retries=3
steps:

steps:
- name: Checkout app code
uses: actions/checkout@v2
with:
Expand Down Expand Up @@ -50,19 +50,19 @@ jobs:
run: npm i

### START Codecov integration ###
- name: Download Codecov binary # step 1
run: curl -Os https://uploader.codecov.io/latest/linux/codecov
- name: Download Codecov CLI Binary # step 1
run: curl -Os https://cli.codecov.io/latest/linux/codecov


### STEPS below are not required, but are great to have for extra security
- name: Verify integrity get GPG
run: curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring --keyring trustedkeys.gpg --import #
run: curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring --keyring trustedkeys.gpg --import # One-time step

- name: Get SHAsums
run: |
curl -Os https://uploader.codecov.io/latest/linux/codecov.SHA256SUM
curl -Os https://uploader.codecov.io/latest/linux/codecov.SHA256SUM.sig


curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM
curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM.sig

## VERIFY integrity
- name: Test Signature
run: gpgv codecov.SHA256SUM.sig codecov.SHA256SUM
Expand All @@ -71,14 +71,14 @@ jobs:
run: shasum -a 256 -c codecov.SHA256SUM

- name: Fix permission #step 2
run: chmod +x codecov
run: sudo chmod +x codecov

# # RUN tests an upload reports ## comment
# - name: Run Service Testsuite with Coverage
# run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml
# RUN tests an upload reports ## comment
- name: Run Service Testsuite with Coverage
run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml

# - name: Upload Service coverage report #step 3
# run: ./codecov ${CODECOV_TOKEN} -F service -f coverage-service.xml
- name: Upload Service coverage report #step 3
run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'service'${{ github.run_id }} -F service -f coverage-service.xml

# - name: Run Controller Testsuite with Coverage
# run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml
Expand All @@ -92,19 +92,22 @@ jobs:
# - name: Upload unit coverage report
# run: ./codecov -F unit -f coverage-unit.xml

- name: Run Complete Testsuite with Coverage
run: vendor/bin/phpunit --coverage-clover=coverage.xml
# - name: Run Complete Testsuite with Coverage
# run: vendor/bin/phpunit --coverage-clover=coverage.xml

# - name: Upload overall coverage report
# run: ./codecov ${CODECOV_TOKEN} -F backend -f coverage.xml

- name: Upload overall coverage report to another repo
run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://doordash.codecov.io -F backend -f coverage.xml
# - name: Upload overall coverage report to another repo
# run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://codecov.io -F backend -f coverage.xml

# - name: Javascript tests using Jest
# run: npm run test

# - name: Upload Javascript coverage
# run: ./codecov -F javascript -f coverage/coverage-final.json
- name: Upload Javascript coverage
env: # Or as an environment variable
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
run: |
./codecov --verbose upload-process --fail-on-error -n 'javascript'${{ github.run_id }} -F 'uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui' -f coverage/coverage-final.json


3 changes: 1 addition & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
"laravel/sail": "^1.0.1",
"mockery/mockery": "^1.4.2",
"nunomaduro/collision": "^5.0",
"phpunit/phpunit": "^9.3.3",
"yoelpc4/laravel-sail-preset": "^0.1.0"
"phpunit/phpunit": "^9.3.3"
},
"config": {
"optimize-autoloader": true,
Expand Down
4 changes: 4 additions & 0 deletions resources/js/classes/person.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,8 @@
getMenuOptions() {
return ['menu options'];
}

getPersonalData() {
return 'secret data';
}
}
Loading