Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a fake test #57

Merged
merged 4 commits into from
Aug 22, 2024
Merged

adding a fake test #57

merged 4 commits into from
Aug 22, 2024

Conversation

vlad-ko
Copy link
Owner

@vlad-ko vlad-ko commented Jun 24, 2024

No description provided.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (0061c7d) to head (ac5d64e).
Report is 5 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Files Patch % Lines
app/Models/ImportantOne.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #57      +/-   ##
============================================
+ Coverage     78.40%   81.35%   +2.94%     
- Complexity        0       15      +15     
============================================
  Files            12       12              
  Lines           176      177       +1     
============================================
+ Hits            138      144       +6     
+ Misses           38       33       -5     
Flag Coverage Δ
controller 50.00% <ø> (ø)
javascript 83.33% <ø> (ø)
service 88.67% <ø> (ø)
unit 60.71% <80.00%> (+19.97%) ⬆️
Components Coverage Δ
backend 78.94% <80.00%> (+3.45%) ⬆️
Files Coverage Δ
app/Models/Charge.php Critical 70.00% <100.00%> (+12.10%) ⬆️
app/Models/ImportantOne.php 75.00% <66.66%> (+75.00%) ⬆️

@vlad-ko
Copy link
Owner Author

vlad-ko commented Jul 29, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Key issues to review

Hardcoded Condition
The condition if (true) in uncoveredUnitTestFunction method is hardcoded and always true, which might not be intended for logical operations.

Logical Error
The method brandNewFunctionHasNoTest uses is_object($this) which will always return true since $this is always an object in the context of a class method.

@vlad-ko vlad-ko merged commit 3312600 into main Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant