Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying +cuXXX and +cpu #3499

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Specifying +cuXXX and +cpu #3499

merged 2 commits into from
Oct 21, 2024

Conversation

Yoinky3000
Copy link
Contributor

Description

For some reason uv cannot resolve torch dependencies correctly unless +cuXXX/+cpu is specified in the torch command env

when I'm installing for cuda without +cuXXX:
image
after I added it:
image

the lint gha in this repo(with uv enabled):
image

Notes

UV docs explained about this kind of situation here:
https://docs.astral.sh/uv/pip/compatibility/#local-version-identifiers

I only edited the torch command for CUDA and CPU only, as I'm not sure about AMD and Intel gpu

Environment and Testing

List the environment you have developed / tested this on

@vladmandic
Copy link
Owner

vladmandic commented Oct 21, 2024

its not just uv, its a major issue overall.

e.g. some packages have torchvision as dependency, but python does not resolve installed torchvision+cu same as torchvision, so it looks like there is no torchvision already installed so it pulls in latest which pulls in latest torch which invalidates torch_command to start with. torch versioning is very well known not to be inline how python versioning is done and it breaks many things.

but ok, i'm wiling to give this a try, i doubt it can make current mess any worse.

@vladmandic vladmandic merged commit cc4f481 into vladmandic:dev Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants