This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Clear system properties in SecurityUtilsTest #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lzx404243, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@lzx404243, VMware has approved your signed contributor license agreement. |
|
Can someone please review this? Any feedback on the changes would be greatly appreciated. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests
com.vmware.admiral.common.util.SecurityUtilsTest.testEnsureTrustStoreSettingsandcom.vmware.admiral.common.util.SecurityUtilsTest.testEnsureTlsDisabledAlgorithmsare not idempotent and fail if run twice in the same JVM, because each of the tests pollutes some states(system properties) shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.The suggested fix to clear the system properties that are set in the tests when each test finishes.
With the proposed fix, the test does not pollute the shared state (and passes when run twice in the same JVM).