Merge pull request #11 from ncdc/add-client-go-auth-providers

Add client-go auth provider plugins

pkg/client/auth_providers.go

@@ -0,0 +1,25 @@
+/*
+Copyright 2017 Heptio Inc.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package client
+
+// Make sure we import the client-go auth provider plugins.
+
+import (
+	_ "k8s.io/client-go/plugin/pkg/client/auth/azure"
+	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
+	_ "k8s.io/client-go/plugin/pkg/client/auth/oidc"
+)

pkg/controller/backup_controller_test.go

@@ -207,7 +207,7 @@ func TestProcessBackup(t *testing.T) {
 				require.Error(t, err, "processBackup should error")
 				return
 			}
-			require.NoErrorf(t, err, "processBackup unexpected error: %v", err)
+			require.NoError(t, err, "processBackup unexpected error: %v", err)
 
 			if !test.expectBackup {
 				assert.Empty(t, backupper.Calls)

pkg/controller/schedule_controller_test.go

@@ -138,7 +138,7 @@ func TestProcessSchedule(t *testing.T) {
 			)
 			if test.fakeClockTime != "" {
 				testTime, err = time.Parse("2006-01-02 15:04:05", test.fakeClockTime)
-				require.NoErrorf(t, err, "unable to parse test.fakeClockTime: %v", err)
+				require.NoError(t, err, "unable to parse test.fakeClockTime: %v", err)
 			}
 			c.clock = clock.NewFakeClock(testTime)
 
@@ -161,7 +161,7 @@ func TestProcessSchedule(t *testing.T) {
 			key := test.scheduleKey
 			if key == "" && test.schedule != nil {
 				key, err = cache.MetaNamespaceKeyFunc(test.schedule)
-				require.NoErrorf(t, err, "error getting key from test.schedule: %v", err)
+				require.NoError(t, err, "error getting key from test.schedule: %v", err)
 			}
 
 			err = c.processSchedule(key)
@@ -246,13 +246,13 @@ func TestGetNextRunTime(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			cronSchedule, err := cron.Parse(test.schedule.Spec.Schedule)
-			require.NoErrorf(t, err, "unable to parse test.schedule.Spec.Schedule: %v", err)
+			require.NoError(t, err, "unable to parse test.schedule.Spec.Schedule: %v", err)
 
 			testClock := clock.NewFakeClock(time.Now())
 
 			if test.lastRanOffset != "" {
 				offsetDuration, err := time.ParseDuration(test.lastRanOffset)
-				require.NoErrorf(t, err, "unable to parse test.lastRanOffset: %v", err)
+				require.NoError(t, err, "unable to parse test.lastRanOffset: %v", err)
 
 				test.schedule.Status.LastBackup = metav1.Time{Time: testClock.Now().Add(-offsetDuration)}
 			}
@@ -360,7 +360,7 @@ func TestGetBackup(t *testing.T) {
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			testTime, err := time.Parse("2006-01-02 15:04:05", test.testClockTime)
-			require.NoErrorf(t, err, "unable to parse test.testClockTime: %v", err)
+			require.NoError(t, err, "unable to parse test.testClockTime: %v", err)
 
 			backup := getBackup(test.schedule, clock.NewFakeClock(testTime).Now())