Issue 6988: udmrepo use region specified in BSL when s3URL is empty

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
vmware-tanzu · Oct 20, 2023 · c9b4d54 · c9b4d54
1 parent ecb4d59
commit c9b4d54
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/changelogs/unreleased/6994-Lyndon-Li b/changelogs/unreleased/6994-Lyndon-Li
@@ -0,0 +1 @@
+Fix #6988, always get region from BSL if it is not empty
diff --git a/pkg/repository/provider/unified_repo.go b/pkg/repository/provider/unified_repo.go
@@ -477,9 +477,11 @@ func getStorageVariables(backupLocation *velerov1api.BackupStorageLocation, repo
 
 		var err error
 		if s3Url == "" {
-			region, err = getS3BucketRegion(bucket)
-			if err != nil {
-				return map[string]string{}, errors.Wrap(err, "error get s3 bucket region")
+			if region == "" {
+				region, err = getS3BucketRegion(bucket)
+				if err != nil {
+					return map[string]string{}, errors.Wrap(err, "error get s3 bucket region")
+				}
 			}
 
 			s3Url = fmt.Sprintf("s3-%s.amazonaws.com", region)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix #6988, always get region from BSL if it is not empty