Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AWS Go sdk to v2 #3338

Closed
carlisia opened this issue Jan 25, 2021 · 2 comments
Closed

Upgrade AWS Go sdk to v2 #3338

carlisia opened this issue Jan 25, 2021 · 2 comments
Assignees
@reasonerjt
Labels
Enhancement/Dev Internal or Developer-focused Enhancement to Velero kind/tech-debt Needs investigation Reviewed Q2 2021
Milestone
v1.13

Comments

@carlisia
Copy link
Contributor

https://github.com/aws/aws-sdk-go-v2/releases
@carlisia carlisia added the Enhancement/Dev Internal or Developer-focused Enhancement to Velero label Jan 25, 2021
@carlisia carlisia added this to the v1.7.0 milestone Jan 25, 2021
@eleanor-millman eleanor-millman modified the milestones: v1.7.0, v1.8.0 Jul 30, 2021
@jglick
Copy link

jglick commented Nov 2, 2021

One thing I noticed when experimenting in vmware-tanzu/velero-plugin-for-aws#90 is that the v2 SDK has a richer system for handling retries, which is rather important here (#1135): client.DefaultRetryer replaced with https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/retries-timeouts/.

@reasonerjt reasonerjt added Needs investigation 1.13-candidate issue/pr that should be considered to target v1.13 minor release and removed Needs investigation 1.13-candidate issue/pr that should be considered to target v1.13 minor release labels Sep 8, 2023
@reasonerjt reasonerjt modified the milestones: Prioritized issues, v1.13 Sep 8, 2023
@reasonerjt
Copy link
Contributor

Fixed by
vmware-tanzu/velero-plugin-for-aws#177
#6923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reasonerjt reasonerjt

Labels
Enhancement/Dev Internal or Developer-focused Enhancement to Velero kind/tech-debt Needs investigation Reviewed Q2 2021
Projects
None yet
Milestone
v1.13
Development

No branches or pull requests
5 participants
@carlisia @jglick @nrb @reasonerjt @eleanor-millman