Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Action bug: If reviewers already assigned, more keep being added #3573

Closed
carlisia opened this issue Mar 12, 2021 · 4 comments · Fixed by #3584
Closed

GH Action bug: If reviewers already assigned, more keep being added #3573

carlisia opened this issue Mar 12, 2021 · 4 comments · Fixed by #3584
Assignees
Labels

Comments

@carlisia
Copy link
Contributor

Issue with our auto assign PR reviewers GH action: It works fine until there's an additional operation to the PR, like changing its state to/from WIP, or, very common, adding additional commits.

This happens now that we are limiting the number of reviewers to a subset of the total.

This is a known issue with the GH Action:

kentaro-m/auto-assign-action#16

I'll keep an eye for this fix and update it in our repos.

@carlisia carlisia added the CI/CD label Mar 12, 2021
@carlisia carlisia self-assigned this Mar 12, 2021
@zubron
Copy link
Contributor

zubron commented Mar 12, 2021

Could we minimise the impact of this by changing the trigger to not include synchronize? My understanding is that by including that event, this job will run again on every push.

I think we'll still encounter this issue if we re-run the checks for the PR, but this should at least stop it being triggered on every push.

@zubron
Copy link
Contributor

zubron commented Mar 12, 2021

Looking at our actions, we also have the PR labeler job within the file for assigning PRs. I think we want that job to run on every push, so we should separate that out into a different action.

@carlisia
Copy link
Contributor Author

Def worth it trying the first, and def a yes for the second. Let me try to improve this. Thanks for taking a look @zubron.

@jenting jenting linked a pull request Mar 16, 2021 that will close this issue
3 tasks
@jenting
Copy link
Contributor

jenting commented Mar 16, 2021

Close it, feel free to reopen if the issue still happens again.

@jenting jenting closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants