Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a default value for SnapshotMoveData #6647

Closed
sseago opened this issue Aug 14, 2023 · 1 comment
Closed

Consider adding a default value for SnapshotMoveData #6647

sseago opened this issue Aug 14, 2023 · 1 comment

Comments

@sseago
Copy link
Collaborator

sseago commented Aug 14, 2023

Describe the problem/challenge you have
For users who will always want to use VBDM for backups instead of plain CSI, they shouldn't have to specify --snapshot-move-data for every backup. We should have an install and server flag for this, similar to what we do for defaultVolumesToFsBackup

Describe the solution you'd like
We should create a server setting for a default value for SnapshotMoveData. When a backup CR does not include the spec.snapshotMoveData field, rather than treating it as false, the velero backup controller should set request.Spec.SnapshotMoveData to the default value set it to the server default value. An install option (and server flag) for --default-snapshot-move-data would need to be added, and the backup controller would supply this default value for backups that do already not specify it.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@sseago sseago added the 1.13-candidate issue/pr that should be considered to target v1.13 minor release label Aug 14, 2023
@reasonerjt reasonerjt added this to the v1.13 milestone Aug 25, 2023
@reasonerjt reasonerjt removed the 1.13-candidate issue/pr that should be considered to target v1.13 minor release label Aug 25, 2023
@Lyndon-Li
Copy link
Contributor

Reopen for 1.12.1

@Lyndon-Li Lyndon-Li reopened this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants