Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port 8085 should be allocated to the server within the node agent pod. #6792

Closed
allenxu404 opened this issue Sep 8, 2023 · 5 comments
Closed
Assignees
Labels
Metrics Related to prometheus metrics
Milestone

Comments

@allenxu404
Copy link
Contributor

allenxu404 commented Sep 8, 2023

What steps did you take and what happened:
No port is allocated to server within node agent as the output below from executing kubectl describe daemonset.apps/node-agent shows :
image

We can also see this issue from log of node agent pod:

time="2023-09-08T08:30:26Z" level=info msg="Starting metric server for node agent at address [:]" logSource="pkg/cmd/cli/nodeagent/server.go:230"

What did you expect to happen:
The server within node agent pod should expose port 8085 similar to how server within velero pod is configured so that the Promethous pod can scrape the pod volume related metrics from that server via port 8085.

The following information will help us better understand what's going on:

If you are using velero v1.7.0+:
Please use velero debug --backup <backupname> --restore <restorename> to generate the support bundle, and attach to this issue, more options please refer to velero debug --help

If you are using earlier versions:
Please provide the output of the following commands (Pasting long output into a GitHub gist or other pastebin is fine.)

  • kubectl logs deployment/velero -n velero
  • velero backup describe <backupname> or kubectl get backup/<backupname> -n velero -o yaml
  • velero backup logs <backupname>
  • velero restore describe <restorename> or kubectl get restore/<restorename> -n velero -o yaml
  • velero restore logs <restorename>

Anything else you would like to add:

Environment:

  • Velero version (use v1.12):
  • Velero features (use velero client config get features):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@blackpiglet blackpiglet added the 1.13-candidate issue/pr that should be considered to target v1.13 minor release label Sep 8, 2023
@allenxu404
Copy link
Contributor Author

I will fix it on v1.13.

@kaovilai
Copy link
Member

kaovilai commented Sep 8, 2023

Is this also not applicable to 1.12?

@yanggangtony
Copy link
Contributor

Hi, I reviewd the code , and found the issue 2 days ago .
And sent a pr to fix it.
Would you please take a look on it?
#6784

@allenxu404

@qiuming-best qiuming-best added this to the v1.13 milestone Sep 12, 2023
@qiuming-best qiuming-best added Metrics Related to prometheus metrics and removed 1.13-candidate issue/pr that should be considered to target v1.13 minor release labels Sep 12, 2023
@allenxu404
Copy link
Contributor Author

@kaovilai It seems that this issue has been persisting for a long time, and it is still present in version 1.12.

@allenxu404
Copy link
Contributor Author

Close this issue as #6784 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metrics Related to prometheus metrics
Projects
None yet
Development

No branches or pull requests

5 participants