Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new metric for BSL #7039

Open
chrislinan opened this issue Oct 31, 2023 · 6 comments
Open

Add a new metric for BSL #7039

chrislinan opened this issue Oct 31, 2023 · 6 comments
Assignees
Labels
kind/requirement Metrics Related to prometheus metrics

Comments

@chrislinan
Copy link

Describe the problem/challenge you have

Can we have a new metric for BSL to show whether BSL is valid or invalid?

Describe the solution you'd like.

add a new metric named "velero_backup_storage_location_last_status" and register this metric in the BSL controller
The behavior may be like the metric "backupLastStatus"

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@Lyndon-Li Lyndon-Li added the Metrics Related to prometheus metrics label Oct 31, 2023
@allenxu404
Copy link
Contributor

Currently we can check the status of BSL either by Velero command line interface or backuprepositories CR. Not sure if adding this new metrics would provide significant value, given these existing methods.

Let's see if there is more feedbacks from other users on this need.

@sseago
Copy link
Collaborator

sseago commented Jan 10, 2024

@allenxu404 Actually, the BSL is the backupstoragelocations CR -- backuprepositories is used for kopia/restic for FS backup.

@allenxu404
Copy link
Contributor

@sseago My bad. Thanks for pointing it out.

@oOoHoCo
Copy link

oOoHoCo commented Mar 4, 2024

👍

I would really like to get a metric for BackupStorageLocation and BackupSnapshotLocation too.
This would make alarming much easier than implementing some job that needs to regularly use the CLI to check.

Copy link

github-actions bot commented May 4, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@github-actions github-actions bot added the staled label May 4, 2024
@kaovilai
Copy link
Member

kaovilai commented May 5, 2024

unstale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/requirement Metrics Related to prometheus metrics
Projects
None yet
Development

No branches or pull requests

7 participants