Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Modifier Follow-on improvements #7050

Open
anshulahuja98 opened this issue Nov 2, 2023 · 10 comments
Open

Resource Modifier Follow-on improvements #7050

anshulahuja98 opened this issue Nov 2, 2023 · 10 comments

Comments

@anshulahuja98
Copy link
Collaborator

anshulahuja98 commented Nov 2, 2023

Describe the problem/challenge you have

JSON Merge Patch and Strategic Merge Patch support was added in resource modifier feature through #6917

There are certain follow on improvements which need to be done in following

Describe the solution you'd like

Anything else you would like to add:

Environment:

  • Velero version (use velero version):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@anshulahuja98 anshulahuja98 added the Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! label Nov 2, 2023
@mailbox171
Copy link

Hello,
btw I would like #6801 (comment) to be reopened please

@anshulahuja98
Copy link
Collaborator Author

Hi @mailbox171 it is tracked in this Issue already. I don't understand what you mean by reopening it.

@mailbox171
Copy link

mailbox171 commented Nov 8, 2023

#6801 (comment) was about the resource modifier not working.
I added a comment to the Issue: since with the latest version the issues are back, that's what I mean with reopening.

In the same issue there were ALSO some possible improvements mentioned, and that's why is tracked here.

@anshulahuja98
Copy link
Collaborator Author

Will get back in some time.

@arsenalzp
Copy link

Hello,
I would like to pick up this issue, however I would like to know is there any deadlines for solving this issue, because I should study this project in details.

@reasonerjt reasonerjt modified the milestone: v1.14 Feb 2, 2024
@reasonerjt reasonerjt added Needs triage We need discussion to understand problem and decide the priority 2024 Q1 reviewed and removed 1.14-candidate Needs triage We need discussion to understand problem and decide the priority labels Feb 2, 2024
@reasonerjt reasonerjt added this to the v1.14 milestone Feb 7, 2024
Copy link

github-actions bot commented Apr 9, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@reasonerjt
Copy link
Contributor

Per discussion with @anshulahuja98, I'm moving this out from v1.14 milestone, will keep this in backlog.

@reasonerjt reasonerjt removed this from the v1.14 milestone Apr 15, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

@kaovilai
Copy link
Member

unstale

@github-actions github-actions bot removed the staled label Jun 16, 2024
@blackpiglet blackpiglet removed the Good first issue Looking to contribute to Velero? Issues with this label might be a great place to start! label Jun 21, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. If a Velero team member has requested log or more information, please provide the output of the shared commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants