Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][release-1.12]Code clean for backup cmd client. (#6750) #6912

Merged

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Oct 3, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Cherry-pick #6750 into release-1.12.

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet changed the title Code clean for backup cmd client. (#6750) [cherry-pick][release-1.12]Code clean for backup cmd client. (#6750) Oct 3, 2023
@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #6912 (0eaf14e) into release-1.12 (c415fd4) will increase coverage by 0.03%.
The diff coverage is 85.71%.

@@               Coverage Diff                @@
##           release-1.12    #6912      +/-   ##
================================================
+ Coverage         60.34%   60.38%   +0.03%     
================================================
  Files               246      246              
  Lines             26232    26228       -4     
================================================
+ Hits              15830    15837       +7     
+ Misses             9286     9277       -9     
+ Partials           1116     1114       -2     
Files Coverage Δ
pkg/controller/backup_controller.go 61.25% <100.00%> (ø)
pkg/controller/backup_deletion_controller.go 49.87% <100.00%> (ø)
pkg/cmd/cli/backup/create.go 67.04% <50.00%> (+0.63%) ⬆️

... and 1 file with indirect coverage changes

Address some code spell check errors.

Signed-off-by: Xun Jiang <jxun@vmware.com>
Copy link
Collaborator

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blackpiglet This PR has some extra changes too other than the cherry-pick ones.

@blackpiglet
Copy link
Contributor Author

@shubham-pampattiwar
Yeah, there was a Github action that reported some code-spell errors. The additional changes are used to address these issues.

@blackpiglet blackpiglet merged commit 175047b into vmware-tanzu:release-1.12 Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation has-changelog has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants