Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up aws sdk to aws-sdk-go-v2 #6923

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

reasonerjt
Copy link
Contributor

@reasonerjt reasonerjt commented Oct 6, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-unit-tests labels Oct 6, 2023
@reasonerjt reasonerjt changed the title Bump up aws sdk to aws-sdk-go-v2 [WIP] Bump up aws sdk to aws-sdk-go-v2 Oct 6, 2023
@reasonerjt reasonerjt requested review from danfengliu and Lyndon-Li and removed request for ywk253100 and qiuming-best October 6, 2023 12:15
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #6923 (b71d2b3) into main (e2ec855) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##             main    #6923      +/-   ##
==========================================
+ Coverage   61.05%   61.07%   +0.02%     
==========================================
  Files         251      251              
  Lines       26846    26839       -7     
==========================================
+ Hits        16390    16392       +2     
+ Misses       9303     9294       -9     
  Partials     1153     1153              
Files Coverage Δ
pkg/repository/provider/unified_repo.go 87.46% <100.00%> (ø)
pkg/repository/config/aws.go 48.14% <50.00%> (+8.80%) ⬆️

... and 2 files with indirect coverage changes

@danfengliu
Copy link
Contributor

From nightly test results, there're 2 type of failures:

  1. SnapshotCreationPerVolumeRateExceeded, this error only occurred occasionally:
    time="2023-10-07T08:55:50Z" level=error msg="Error backing up item" backup=velero/backup-1-9f346451-1fcc-4733-bfcc-574b1ee3ea04 error="error taking snapshot of volume: rpc error: code = Unknown desc = operation error EC2: CreateSnapshot, https response error StatusCode: 400, RequestID: xxxxxxxx, api error SnapshotCreationPerVolumeRateExceeded: The maximum per volume CreateSnapshot request rate has been exceeded. Use an increasing or variable sleep interval between requests." logSource="pkg/backup/backup.go:448" name=kibishii-deployment-0

  2. ListObjectsV2 error on Minio :
    time="2023-10-07T08:38:25Z" level=error msg="fail to validate backup store" backup-storage-location=velero/bsl-cdc017e5-8459-4bf9-bb27-20db3b8c108d controller=backup-storage-location error="rpc error: code = Unknown desc = operation error S3: ListObjectsV2, https response error StatusCode: 403, RequestID: xxxxxx, HostID: xxxxxxxx, api error InvalidAccessKeyId: The Access Key Id you provided does not exist in our records." error.file="/go/src/github.com/vmware-tanzu/velero/pkg/persistence/object_store.go:198" error.function="github.com/vmware-tanzu/velero/pkg/persistence.(*objectBackupStore).IsValid" logSource="pkg/controller/backup_storage_location_controller.go:151"

@danfengliu
Copy link
Contributor

Regarding Minio access failure, it's only under condition of deploy Minio using clusterIP type of service with URL service-name.namespace.svc:service-port instead of nodePort with IP address:

@reasonerjt reasonerjt force-pushed the aws-sdk-v2 branch 2 times, most recently from 04446a4 to 597108c Compare October 24, 2023 08:59
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
@reasonerjt reasonerjt changed the title [WIP] Bump up aws sdk to aws-sdk-go-v2 Bump up aws sdk to aws-sdk-go-v2 Oct 24, 2023
@kaovilai
Copy link
Member

FYI this pr conflicts with #6995. When this merge, I will rebase #6995 and add unit tests to prevent future regressions

@reasonerjt
Copy link
Contributor Author

Thanks @kaovilai

@reasonerjt reasonerjt merged commit 317db25 into vmware-tanzu:main Oct 24, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file has-changelog has-unit-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants