-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Kopia file parallelism configurable #7000
Make Kopia file parallelism configurable #7000
Conversation
ab2886d
to
ce93253
Compare
90f6393
to
9e0a893
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7000 +/- ##
=======================================
Coverage 61.68% 61.69%
=======================================
Files 258 258
Lines 27613 27636 +23
=======================================
+ Hits 17034 17050 +16
- Misses 9387 9393 +6
- Partials 1192 1193 +1 ☔ View full report in Codecov by Sentry. |
f444e7f
to
d754946
Compare
Signed-off-by: Ming <mqiu@vmware.com>
d754946
to
481cb60
Compare
@@ -477,6 +477,15 @@ spec: | |||
description: TTL is a time.Duration-parseable string describing how | |||
long the Backup should be retained for. | |||
type: string | |||
uploaderConfig: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a late comment, didn't get a chance to review the design.
just wondering if we evaluated between passing this value as part of backup/restore API vs making it a server setting?
Any rationales around this.
From my thinking, a user might not really wish to use different uploaderconfig for each backup and might just prefer to have it set once at server level. This might be sufficient for most use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anshulahuja98
Thank you for your suggestion; we have internally discussed this matter. Due to the various configuration options in Velero, the placement of these configurations is relatively unclear. We believe that some configurations can be placed at the server level, while others are associated with backup or restore. To clearly define the location of configurations, we have decided to place configurations related to backup or restore in the respective Backup or Restore Custom Resource (CR). Currently, aspects such as concurrency control and upcoming tasks like Kopia Sparse and Ignore Folder parameters are all linked to specific backup or restore operations and will therefore be placed in the corresponding CRs. Of course, we will also consider how to better distinguish where these configurations should be placed in the future.
…pia-parallelism
…pia-parallelism
c2d4495
@Lyndon-Li @blackpiglet If we do not set this value/flag during backup/schedule creation, What will be default value of parallel files upload ? I tried to find it, didn't find anywhere in doc. Also if there is any document you can point me to about difference between node-agent concurrency and parallel files upload. Thanks |
@navilg |
Ohkay. Does parallel set value 1 means two files can be uploaded at a time ? |
AFAIK, 1 means only one parallel. 2 means two files can be uploaded concurrently. |
Thank you for contributing to Velero!
Please add a summary of your change
Implementation of #7005
Does your change fix a particular issue?
Fixes #(issue)
#6607
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.