Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6663: changes for configurable data path concurrency #7059

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

Lyndon-Li
Copy link
Contributor

Add the implementation for design #6950, configurable data path concurrency

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #7059 (db43200) into main (866fbb5) will increase coverage by 0.11%.
Report is 2 commits behind head on main.
The diff coverage is 88.31%.

@@            Coverage Diff             @@
##             main    #7059      +/-   ##
==========================================
+ Coverage   61.02%   61.13%   +0.11%     
==========================================
  Files         255      256       +1     
  Lines       27040    27143     +103     
==========================================
+ Hits        16500    16594      +94     
- Misses       9361     9368       +7     
- Partials     1179     1181       +2     
Files Coverage Δ
pkg/controller/data_download_controller.go 75.27% <100.00%> (ø)
pkg/controller/data_upload_controller.go 68.38% <100.00%> (ø)
pkg/nodeagent/node_agent.go 89.09% <100.00%> (ø)
pkg/controller/pod_volume_backup_controller.go 22.36% <0.00%> (ø)
pkg/controller/pod_volume_restore_controller.go 20.16% <0.00%> (ø)
pkg/cmd/cli/nodeagent/server.go 20.05% <86.53%> (+11.19%) ⬆️

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li marked this pull request as ready for review November 6, 2023 12:30
pkg/cmd/cli/nodeagent/server.go Show resolved Hide resolved
pkg/nodeagent/node_agent.go Outdated Show resolved Hide resolved
pkg/nodeagent/node_agent.go Show resolved Hide resolved
@github-actions github-actions bot added the Area/Design Design Documents label Nov 8, 2023
@Lyndon-Li Lyndon-Li force-pushed the issue-fix-6663 branch 3 times, most recently from 721b0dc to 348dbb5 Compare November 8, 2023 03:57
@Lyndon-Li Lyndon-Li requested a review from ywk253100 November 8, 2023 03:58
ywk253100
ywk253100 previously approved these changes Nov 8, 2023
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@qiuming-best qiuming-best merged commit 76e89f7 into vmware-tanzu:main Nov 9, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants