Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip syncing the backup which doesn't contain backup metadata #7081

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ywk253100
Copy link
Contributor

Skip syncing the backup which doesn't contain backup metadata

Fixes #6849

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Skip syncing the backup which doesn't contain backup metadata

Fixes vmware-tanzu#6849

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #7081 (84c9604) into main (cb5ffe2) will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #7081      +/-   ##
==========================================
- Coverage   61.16%   61.15%   -0.02%     
==========================================
  Files         256      256              
  Lines       27222    27229       +7     
==========================================
+ Hits        16650    16651       +1     
- Misses       9389     9393       +4     
- Partials     1183     1185       +2     
Files Coverage Δ
pkg/controller/backup_sync_controller.go 44.48% <14.28%> (-0.71%) ⬇️

@ywk253100 ywk253100 merged commit d345bda into vmware-tanzu:main Nov 15, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folders in S3 object store bucket not containing a backup cause error
4 participants