Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong reference link in design docs. #7086

Merged

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Nov 10, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Like the pics , when i redirect the link , it is not right for me .
image
image

And I also search other place for fix this problem.
Just found 2 at present.
Maybe the user of design forget to update the place when he/she complete this feature, then the docs is moved to Implemented ,But the reference is not...

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: yanggang <gang.yang@daocloud.io>
@github-actions github-actions bot added the Area/Design Design Documents label Nov 10, 2023
@github-actions github-actions bot requested review from Lyndon-Li and sseago November 10, 2023 23:00
@yanggangtony
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #7086 (7fd692e) into main (cb5ffe2) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7086      +/-   ##
==========================================
- Coverage   61.16%   61.13%   -0.03%     
==========================================
  Files         256      256              
  Lines       27222    27222              
==========================================
- Hits        16650    16642       -8     
- Misses       9389     9396       +7     
- Partials     1183     1184       +1     

see 1 file with indirect coverage changes

@reasonerjt reasonerjt merged commit e826b70 into vmware-tanzu:main Nov 13, 2023
8 of 10 checks passed
@yanggangtony yanggangtony deleted the fix-design-wrong-reference-link branch November 13, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/Design Design Documents kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants