-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook status to backup/restore CR #7117
Conversation
225c523
to
7ec29f9
Compare
d23c26a
to
d29d064
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7117 +/- ##
==========================================
+ Coverage 61.66% 61.80% +0.13%
==========================================
Files 258 259 +1
Lines 27636 27859 +223
==========================================
+ Hits 17042 17218 +176
- Misses 9400 9438 +38
- Partials 1194 1203 +9 ☔ View full report in Codecov by Sentry. |
The error of the hooks should be passed to the controllers in a more explicit way, and reflect in the Status of the CRs |
d29d064
to
e160a9d
Compare
e160a9d
to
be41a23
Compare
hookFailed
to backup/restore describerbe41a23
to
ed5b003
Compare
8a3b759
to
11d1857
Compare
Sync with @anshulahuja98, this PR solely adds the "hooksAttempted" and "hooksFailed" fields to backup/restore CR to provide initial hook execution metadata. Tracking additional details like hook error information and skipped hooks can be supported in the future via a separate follow-up effort. Once this PR is merged, I will create a new issue to track these potential enhancements. |
Signed-off-by: allenxu404 <qix2@vmware.com>
11d1857
to
5d1a632
Compare
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #6567
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.