-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use VolumeInfo to help restore the PV. #7138
Merged
reasonerjt
merged 3 commits into
vmware-tanzu:main
from
blackpiglet:6595_volumeinfo_restore
Dec 5, 2023
Merged
Use VolumeInfo to help restore the PV. #7138
reasonerjt
merged 3 commits into
vmware-tanzu:main
from
blackpiglet:6595_volumeinfo_restore
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
from
November 22, 2023 10:37
f07b2f3
to
259b533
Compare
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
2 times, most recently
from
November 22, 2023 10:52
f0c2918
to
ea62367
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7138 +/- ##
==========================================
- Coverage 61.94% 61.80% -0.15%
==========================================
Files 259 261 +2
Lines 27903 27968 +65
==========================================
+ Hits 17285 17286 +1
- Misses 9410 9465 +55
- Partials 1208 1217 +9 ☔ View full report in Codecov by Sentry. |
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
from
November 22, 2023 11:39
ea62367
to
159fd06
Compare
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
3 times, most recently
from
November 22, 2023 14:58
6b3dcc1
to
0a7df10
Compare
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
4 times, most recently
from
November 23, 2023 08:28
a05f7b9
to
b2d3c06
Compare
reasonerjt
reviewed
Nov 24, 2023
reasonerjt
reviewed
Nov 24, 2023
Please also make sure the PVMap's key is not mixed with PV and PVC. |
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
4 times, most recently
from
November 27, 2023 02:06
2d595b5
to
2dd9b0a
Compare
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
16 times, most recently
from
November 30, 2023 14:52
7f2d911
to
ac2bd0a
Compare
Add VolumeInfo for left PVs during backup. Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
2 times, most recently
from
December 4, 2023 06:16
65307b9
to
cdde8b2
Compare
reasonerjt
previously approved these changes
Dec 5, 2023
allenxu404
approved these changes
Dec 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
blackpiglet
force-pushed
the
6595_volumeinfo_restore
branch
from
December 5, 2023 02:01
cdde8b2
to
28df14d
Compare
Lyndon-Li
approved these changes
Dec 5, 2023
reasonerjt
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.