Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VolumeInfo to help restore the PV. #7138

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Nov 22, 2023

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch from f07b2f3 to 259b533 Compare November 22, 2023 10:37
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch 2 times, most recently from f0c2918 to ea62367 Compare November 22, 2023 10:52
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (a318e1d) 61.94% compared to head (28df14d) 61.80%.
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/restore/restore.go 75.15% 30 Missing and 10 partials ⚠️
internal/volume/volumes_information.go 87.50% 31 Missing and 4 partials ⚠️
pkg/backup/request.go 0.00% 11 Missing ⚠️
pkg/controller/restore_controller.go 30.00% 4 Missing and 3 partials ⚠️
pkg/controller/backup_controller.go 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7138      +/-   ##
==========================================
- Coverage   61.94%   61.80%   -0.15%     
==========================================
  Files         259      261       +2     
  Lines       27903    27968      +65     
==========================================
+ Hits        17285    17286       +1     
- Misses       9410     9465      +55     
- Partials     1208     1217       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch from ea62367 to 159fd06 Compare November 22, 2023 11:39
@blackpiglet blackpiglet marked this pull request as ready for review November 22, 2023 11:42
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch 3 times, most recently from 6b3dcc1 to 0a7df10 Compare November 22, 2023 14:58
@blackpiglet blackpiglet marked this pull request as draft November 22, 2023 16:16
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch 4 times, most recently from a05f7b9 to b2d3c06 Compare November 23, 2023 08:28
@blackpiglet blackpiglet marked this pull request as ready for review November 23, 2023 09:27
@reasonerjt
Copy link
Contributor

Please also make sure the PVMap's key is not mixed with PV and PVC.

@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch 4 times, most recently from 2d595b5 to 2dd9b0a Compare November 27, 2023 02:06
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch 16 times, most recently from 7f2d911 to ac2bd0a Compare November 30, 2023 14:52
Xun Jiang added 2 commits December 4, 2023 08:33
Add VolumeInfo for left PVs during backup.

Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet force-pushed the 6595_volumeinfo_restore branch 2 times, most recently from 65307b9 to cdde8b2 Compare December 4, 2023 06:16
@reasonerjt reasonerjt added this to the v1.13 milestone Dec 4, 2023
reasonerjt
reasonerjt previously approved these changes Dec 5, 2023
Signed-off-by: Xun Jiang <jxun@vmware.com>
@reasonerjt reasonerjt merged commit f2ba625 into vmware-tanzu:main Dec 5, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants