Add resource consumption in fs-backup and data mover doc #7604
Conversation
Lyndon-Li
added
the
kind/changelog-not-required
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Lyndon-Li
force-pushed
the
resource-consumption-in-doc
branch
from
72a8d43 to
49cd345
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7604 +/- ##
=======================================
Coverage 61.88% 61.88%
=======================================
Files 266 266
Lines 29456 29456
=======================================
Hits 18230 18230
Misses 9934 9934
Partials 1292 1292 ☔ View full report in Codecov by Sentry. |
| @@ -241,14 +241,11 @@ kubectl -n velero get datadownloads -l velero.io/restore-name=YOUR_RESTORE_NAME | |||
|
|
|||
| ## Limitations | |||
|
|
|||
| - CSI and CSI snapshot support both file system volume mode and block volume mode. At present, Velero built-in data mover doesn't support | |||
| block mode volume or volume snapshot. | |||
| - CSI and CSI snapshot support both file system volume mode and block volume mode. At present, block mode is only supported for non-Windows platforms, because the block mode code invokes some system calls that are not present in the Windows platform. | |||
There was a problem hiding this comment.
I think it is better to have inclusive language like we only support linux or UNIX-like platforms, because non-Windows could imply many other OSes block mode support.
There was a problem hiding this comment.
This block is added by #7013, here in this PR, I just moved it since the first clarification and this one are contradictory.
Loop in @blackpiglet who had created #7013.
There was a problem hiding this comment.
It's tricky to describe the compatibility of the block mode support.
The error raised on the Windows system is:
# github.com/vmware-tanzu/velero/pkg/uploader/kopia
pkg/uploader/kopia/block_backup.go:41:31: undefined: syscall.Stat_t
pkg/uploader/kopia/block_restore.go:94:31: undefined: syscall.Stat_t
I checked the packages define Stat_t in https://github.com/golang/go/blob/master/src/syscall.
It seems inaccurate to say UNIX-like platforms support the block mode because the plan-9 and the Illumos packages don't have the Stat_t structure.
And JavaScript and WebAssembly system call also provides the Stat_t.
Maybe we can say UNIX-like platforms support the block mode, but there are some exceptions, then give this link https://github.com/golang/go/blob/master/src/syscall for user's reference.
Add resource consumption in fs-backup and data mover doc. For issue #7391 and #7499