static checks #8071
Merged
static checks #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
github-actions
bot
added
has-unit-tests
and removed
kind/changelog-not-required
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/nilness#cond:~:text=p%20%3A%3D%20%26v%0A...%0Aif%20p%20!%3D%20nil%20%7B%20//%20tautological%20condition%0A%7D Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8071 +/- ##
==========================================
- Coverage 58.79% 58.76% -0.04%
==========================================
Files 357 358 +1
Lines 29841 30107 +266
==========================================
+ Hits 17545 17692 +147
- Misses 10851 10967 +116
- Partials 1445 1448 +3 ☔ View full report in Codecov by Sentry. |
mateusoliveira43
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
To avoid similar problems in the future, we need to fix #7581
blackpiglet
approved these changes
Aug 2, 2024
| @@ -311,7 +311,7 @@ func (ctx *finalizerContext) patchDynamicPVWithVolumeInfo() (errs results.Result | |||
| // We are handling a common but specific scenario where a PVC is in a pending state and uses a storage class with | |||
| // VolumeBindingMode set to WaitForFirstConsumer. In this case, the PV patch step is skipped to avoid | |||
| // failures due to the PVC not being bound, which could cause a timeout and result in a failed restore. | |||
| if pvc != nil && pvc.Status.Phase == v1.ClaimPending { | |||
There was a problem hiding this comment.
should we do pvc.status == nil?
That could be nil right?
There was a problem hiding this comment.
Tried and got an error
anshulahuja98
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.