-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux windows hybrid deploy #8504
Linux windows hybrid deploy #8504
Conversation
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
05c02d9
to
8168ce2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8504 +/- ##
==========================================
+ Coverage 59.18% 59.19% +0.01%
==========================================
Files 369 369
Lines 39329 39408 +79
==========================================
+ Hits 23276 23327 +51
- Misses 14585 14612 +27
- Partials 1468 1469 +1 ☔ View full report in Codecov by Sentry. |
8168ce2
to
9f196b5
Compare
9f196b5
to
2ed820d
Compare
Cache: cacheOption, | ||
}) | ||
|
||
var mgr manager.Manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This retry is to resolve the problem that in some Windows env, the pod network is not immediately ready. Without this, the pod may restart for several times
Technically, we don't need to distinguish different OS types for install, node-agent and node-agent-windows ds instance could be installed in both OS all the time. |
I don't see a problem with 0 scheduled daemonsets. It's not taking up any major resources. |
Thanks @Lyndon-Li
|
As the discussion: |
2ed820d
to
f94b6a7
Compare
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
f94b6a7
to
11cd6d9
Compare
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
d4e491e
to
fe0a45e
Compare
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
79ff23d
to
4ad9c24
Compare
Fix issue #8416, #8417, deploy Velero server and node-agent in linux/Windows hybrid env:
--use-node-agent
is specified; node-agent-windows daemonset is deployed when--use-node-agent-windows
is specifieddesiredNumberScheduled
for node-agent-windows is 0desiredNumberScheduled
for node-agent is 0desiredNumberScheduled
for node-agent-windows is the number of Windows nodes;desiredNumberScheduled
for node-agent is the number of linux nodes