Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Modify the schedule cases. #8531

Merged

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Dec 19, 2024

  • Modify the OrderResource case's verification code.
  • Simplify the Periodical case.
  • Simplify the InProgess case.
  • Prettify the code.
  • Replace math/rand with crypto/rand
  • Replace PollUnitl with PollUntilContextTimeout

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

* Modify the OrderResource case's verification code.
* Simplify the Periodical case.
* Simplify the InProgess case.
* Prettify the code.
* Replace math/rand with crypto/rand
* Replace PollUnitl with PollUntilContextTimeout

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Dec 19, 2024
@blackpiglet blackpiglet marked this pull request as ready for review December 19, 2024 08:07
@github-actions github-actions bot requested review from sseago and ywk253100 December 19, 2024 08:07
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.11%. Comparing base (49a8e24) to head (57f873b).
Report is 2 commits behind head on release-1.15.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15    #8531      +/-   ##
================================================
- Coverage         59.12%   59.11%   -0.02%     
================================================
  Files               367      367              
  Lines             39118    39118              
================================================
- Hits              23130    23126       -4     
- Misses            14520    14523       +3     
- Partials           1468     1469       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 merged commit 2b8b6dc into vmware-tanzu:release-1.15 Dec 19, 2024
49 of 51 checks passed
@blackpiglet blackpiglet changed the title Modify the schedule cases. [cherry-pick] Modify the schedule cases. Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants