Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows toleration to data mover pods #8606

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #8418, add Windows toleration to data mover pods

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li force-pushed the data-mover-pod-misc-enhancement-for-windows branch from 82f22a6 to 5dedaca Compare January 13, 2025 07:30
@Lyndon-Li Lyndon-Li marked this pull request as ready for review January 13, 2025 07:31
@Lyndon-Li Lyndon-Li requested a review from blackpiglet January 13, 2025 07:32
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Project coverage is 59.17%. Comparing base (3207619) to head (5dedaca).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/exposer/csi_snapshot.go 22.22% 7 Missing ⚠️
pkg/exposer/generic_restore.go 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8606      +/-   ##
==========================================
- Coverage   59.20%   59.17%   -0.04%     
==========================================
  Files         370      370              
  Lines       39718    39773      +55     
==========================================
+ Hits        23516    23534      +18     
- Misses      14715    14743      +28     
- Partials     1487     1496       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li merged commit 5f7bf64 into vmware-tanzu:main Jan 13, 2025
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants