Avoid error logs in BenchmarkMultipleExportersToCollector #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
antoninbas
commented
Sep 29, 2023
antoninbas
commented
- Gracefully shutdown exporter connections before stopping collector.
- Do not log an error for graceful client shutdown (EOF error).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 73.53% 73.48% -0.05%
==========================================
Files 18 18
Lines 2792 2795 +3
==========================================
+ Hits 2053 2054 +1
- Misses 572 574 +2
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Gracefully shutdown exporter connections before stopping collector. * Do not log an error for graceful client shutdown (EOF error). Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
avoid-misleading-error-messages-in-BenchmarkMultipleExportersToCollector
branch
from
9bf9b57
to
b494921
Compare
heanlan
approved these changes
Sep 29, 2023
antoninbas
deleted the
avoid-misleading-error-messages-in-BenchmarkMultipleExportersToCollector
branch
dreamtalen
pushed a commit
to dreamtalen/go-ipfix
that referenced
this pull request
Oct 2, 2023
* Gracefully shutdown exporter connections before stopping collector. * Do not log an error for graceful client shutdown (EOF error). Signed-off-by: Antonin Bas <abas@vmware.com>
dreamtalen
pushed a commit
that referenced
this pull request
Oct 2, 2023
* Gracefully shutdown exporter connections before stopping collector. * Do not log an error for graceful client shutdown (EOF error). Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.