Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in integration tests #325

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Improvements in integration tests #325

merged 2 commits into from
Oct 2, 2023

Conversation

antoninbas
Copy link
Member

  • Use more meaningful byte counts in test records (count and reverseCount have no reason to be the same).
  • Generate test data packets automatically using a function, instead of having to generate packet data manually.

@antoninbas
Improvements in integration tests
e7982fa 
* Use more meaningful byte counts in test records (count and
  reverseCount have no reason to be the same).
* Generate test data packets automatically using a function, instead of
  having to generate packet data manually.

Signed-off-by: Antonin Bas <abas@vmware.com>
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #325 (01a7903) into main (f5c5793) will increase coverage by 0.25%.
The diff coverage is 95.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   73.42%   73.67%   +0.25%     
==========================================
  Files          18       19       +1     
  Lines        2796     2800       +4     
==========================================
+ Hits         2053     2063      +10     
+ Misses        576      572       -4     
+ Partials      167      165       -2
Flag Coverage Δ
integration-tests 53.82% <76.19%> (+2.28%) ⬆️
unit-tests 72.53% <95.23%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/exporter/msg.go 100.00% <100.00%> (ø)
pkg/exporter/process.go 56.90% <75.00%> (-2.23%) ⬇️

... and 2 files with indirect coverage changes

@antoninbas
Add integration build tag for linters
01a7903 
Signed-off-by: Antonin Bas <abas@vmware.com>
dreamtalen
dreamtalen approved these changes Oct 2, 2023
View reviewed changes
Copy link

@dreamtalen dreamtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit dac635b into vmware:main Oct 2, 2023
9 checks passed
@antoninbas antoninbas deleted the improve-integration-tests branch October 2, 2023 21:49
dreamtalen pushed a commit to dreamtalen/go-ipfix that referenced this pull request Oct 2, 2023
@antoninbas
Improvements in integration tests (vmware#325)
06f6636 
* Use more meaningful byte counts in test records (count and
  reverseCount have no reason to be the same).
* Generate test data packets automatically using a function, instead of
  having to generate packet data manually.
* Add integration build tag for linters

Signed-off-by: Antonin Bas <abas@vmware.com>
dreamtalen pushed a commit that referenced this pull request Oct 2, 2023
@antoninbas
Improvements in integration tests (#325)
5b139ad 
* Use more meaningful byte counts in test records (count and
  reverseCount have no reason to be the same).
* Generate test data packets automatically using a function, instead of
  having to generate packet data manually.
* Add integration build tag for linters

Signed-off-by: Antonin Bas <abas@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamtalen dreamtalen dreamtalen approved these changes

@heanlan heanlan Awaiting requested review from heanlan

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoninbas @dreamtalen @vmwclabot