Changes for release v0.8.0 #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ondsFromDestinationNode (vmware#320) flowEndSecondsFromDestinationNode and flowEndSecondsFromDestinationNode are changed to the type DateTimesecond Signed-off-by: Tushar Tathgur <tathgurt@tathgurtPNQHP.vmware.com> Co-authored-by: Tushar Tathgur <tathgurt@tathgurtPNQHP.vmware.com>
* Use the copy built-in to copy string bytes to buffer, instead of copying bytes one-by-one with a for loop. This is more efficient (confirmed with new Benchmark functions) and more correct (in case the string includes UTF-8 characters which use more than 1 byte). * Increase max string length from 65,534 to 65,535 (as per the IPFIX RFC 7011). Signed-off-by: Antonin Bas <abas@vmware.com>
* L7 Visibility support in Antrea Signed-off-by: Tushar Tathgur <tathgurt@tathgurtPNQHP.vmware.com> * Replaced isL7 bool with l7ProtocolName string Signed-off-by: Tushar Tathgur <tathgurt@tathgurtPNQHP.vmware.com> --------- Signed-off-by: Tushar Tathgur <tathgurt@tathgurtPNQHP.vmware.com> Co-authored-by: Tushar Tathgur <tathgurt@tathgurtPNQHP.vmware.com>
* Gracefully shutdown exporter connections before stopping collector. * Do not log an error for graceful client shutdown (EOF error). Signed-off-by: Antonin Bas <abas@vmware.com>
Just like for stats, throughput common fields should only be updated for the "latest" record (based on "flowEndSeconds"). This bug explains why the TestCollectorToIntermediate integration test has been flaky for a long time. In some cases, the record from the destination was processed before the record from the source (we have 2 aggregation workers, so records are not guaranteed to be processed in the order in which they are received). While the destination record has a larger "flowEndSeconds", the "throughput" and "reverseThroughput" common elements were overriden by values from the source record. Signed-off-by: Antonin Bas <abas@vmware.com>
* Use more meaningful byte counts in test records (count and reverseCount have no reason to be the same). * Generate test data packets automatically using a function, instead of having to generate packet data manually. * Add integration build tag for linters Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Yongming Ding <dyongming@vmware.com>
Signed-off-by: Yongming Ding <dyongming@vmware.com>
|
@dreamtalen looks like there is some issue with your PR, maybe you didn't use an up-to-date branch locally? |
Yes I should create a release-0.8.0 branch first, please check my new PR: #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.